Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow wrapping on language name (简体中文) #108

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

xicri
Copy link
Owner

@xicri xicri commented May 23, 2023

Closes #86

@xicri xicri self-assigned this May 23, 2023
@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
genshin-dictionary ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2023 5:43am

@xicri
Copy link
Owner Author

xicri commented May 23, 2023

@Bill-Haku
This PR is a fix for #86. Can you help me with testing it when you have time? I could not reproduce this issue in the Japanese environment.

  1. Can you check if this issue happens on production on your end? (Chrome, Safari)
  2. Can you test if it is fixed on the preview environment for this branch? (Chrome, Safari)

I planned to resolve this issue by using web fonts, but because I found I need a long time to implement web fonts, I created this PR as a quick fix.

@Bill-Haku
Copy link
Contributor

On Safari, it looks fine:
image

But on Chrome, the problem comes out:
image

But I failed to open the preview environment on my end:
image

@xicri
Copy link
Owner Author

xicri commented May 23, 2023

@Bill-Haku Oh, sorry, I failed to disable authentication on preview environment. I will check my config.

@xicri
Copy link
Owner Author

xicri commented May 23, 2023

@Bill-Haku Can you try again? Now the authentication should be disabled.

@Bill-Haku
Copy link
Contributor

Thanks, it looks like the problem is fixed and both on chrome and safari it looks fine.
image

@xicri
Copy link
Owner Author

xicri commented May 23, 2023

@Bill-Haku Thanks! I will deploy this fix on production.

@xicri xicri merged commit 325b9bb into main May 23, 2023
7 checks passed
@xicri xicri deleted the fix-cn-linebreak branch May 23, 2023 12:17
xicri added a commit that referenced this pull request May 30, 2023
This commit reverts migration to Next.js from Nuxt 2. Next.js consts too much for a personal development. I will migrate to Nuxt 3 instead.
This commit reverts PRs #93, #101, #104, #105, #106, #107, #108, #109, #110, #111, #112, #113 and #114.

Apply following PR manually after migration to Nuxt 3:

Check if I need to manually apply following PRs:
xicri added a commit that referenced this pull request May 30, 2023
This commit reverts migration to Next.js from Nuxt 2. Next.js consts too much for personal projects. I will migrate to Nuxt 3 instead.
This commit reverts PRs #93, #101, #104, #105, #106, #107, #108, #109, #110, #111, #112, #113 and #114.

Apply following PR manually after migration to Nuxt 3:

Check if I need to manually apply following PRs:
xicri added a commit that referenced this pull request May 30, 2023
This commit reverts migration to Next.js from Nuxt 2. Next.js consts too much for personal projects. I will migrate to Nuxt 3 instead.
This commit reverts PRs #93, #101, #104, #105, #106, #107, #108, #109, #110, #111, #112, #113 and #114.

The following PRs should be manually applied after migration to Nuxt 3:

#106 #107 #108 #110 #111 #112 #114

Check if the following PRs should be applied manually after the migration to Nuxt 3:

#101 #105
xicri added a commit that referenced this pull request May 30, 2023
This commit reverts migration to Next.js from Nuxt 2. Next.js costs too much for personal projects. I will migrate to Nuxt 3 instead.
This commit reverts PRs #93, #101, #104, #105, #106, #107, #108, #109, #110, #111, #112, #113 and #114.

The following PRs should be manually applied after migration to Nuxt 3:

#106 #107 #108 #110 #111 #112 #114

Check if the following PRs should be applied manually after the migration to Nuxt 3:

#101 #105
@xicri xicri mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Chinese mode, the display of the text "Simplified Chinese:" will result in an extra line.
2 participants