Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow wrapping on language name (简体中文) #117

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

xicri
Copy link
Owner

@xicri xicri commented Jun 18, 2023

Closes #86

This bug is fixed by #108 before, but it was reverted by #115. This PR applies the same fix again.

@xicri xicri self-assigned this Jun 18, 2023
@xicri
Copy link
Owner Author

xicri commented Jun 18, 2023

This PR should be merged after Nuxt 3 migration is merged to main.
Don't forget to switch the target branch from nuxt3 to main.
→ Nuxt 3 migration completed.

@xicri xicri added the bug Something isn't working label Jun 18, 2023
@xicri xicri force-pushed the nuxt3 branch 11 times, most recently from 61c9cbb to 6427d17 Compare July 16, 2023 11:20
Base automatically changed from nuxt3 to main July 16, 2023 11:29
@xicri xicri force-pushed the fix-cn-linebreak-nuxt branch 2 times, most recently from 5e13135 to b45e112 Compare July 16, 2023 22:12
@xicri
Copy link
Owner Author

xicri commented Jul 16, 2023

@SleepyAsh0191
Sorry for letting you wait for a long time, but now I'm fixing #86. Can you help me with testing it when you have time? I could not reproduce this issue in the Japanese environment.

  1. Can you check if this issue happens on production on your end?
  2. Can you test if it is fixed on the staging environment for this branch?

On PC, please use Google Chrome, and Safari if you have Mac.
On mobile, please use Google Chrome if you use Android, or Safari if you use iOS.

Template to fill the result:

PC Chrome Mobile Chrome / Mobile Safari
production bug reproduced / bug not reproduced bug reproduced / bug not reproduced
staging fixed / not fixed fixed / not fixed

@xicri xicri marked this pull request as ready for review July 16, 2023 22:30
@xicri xicri merged commit 3aebc7c into main Sep 1, 2023
6 checks passed
@xicri xicri deleted the fix-cn-linebreak-nuxt branch September 1, 2023 11:45
@xicri
Copy link
Owner Author

xicri commented Sep 1, 2023

@SleepyAsh0191 I have deployed this PR. If you find this bug (#86) is not fixed correctly, feel free to reopen it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Chinese mode, the display of the text "Simplified Chinese:" will result in an extra line.
1 participant