Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra space before links #57

Merged
merged 2 commits into from
Apr 15, 2016

Conversation

ehsandarroudi
Copy link
Contributor

As already described in issue #56, given:

(<a href="http://foobar.com">link</a>)

I would expect to see:

([link](http://foobar.com))

But the actual result has an extra space after the left parenthesis:

( [link](http://foobar.com))

The implementation also handles the case when there is an exclamation mark before the link (by adding a space).

@eturino
Copy link

eturino commented Apr 15, 2016

is there any reason not to merge this one? @xijo

@ehsandarroudi
Copy link
Contributor Author

I'm not sure if there are any practical cases left where an exclamation point before the link would be concatenated without a space in between (and thus make it an image).
The second commit (966e3d7) deals with cases like this:

<span>!</span><span><a href="http://link.com">link</a></span>

Please let me know if there's anything else I can improve.

@xijo
Copy link
Owner

xijo commented Apr 15, 2016

@Easy-D @eturino Thanks for the reminder, you're right. I'll merge it right in and release it soon. Thanks for your contribution!

@xijo xijo merged commit 3406f3a into xijo:master Apr 15, 2016
@eturino
Copy link

eturino commented Apr 20, 2016

thanks @Easy-D and @xijo.

Any plans on releasing a version with this change?

@xijo
Copy link
Owner

xijo commented Apr 20, 2016

@eturino I wanted to wait for another PR to get finished, but if you're waiting for it here you go: released as 1.0.2

@eturino
Copy link

eturino commented Apr 20, 2016

@xijo thanks a lot! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants