Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCL buffers don't support Vitis sw_emu #56

Open
Mellich opened this issue May 19, 2022 · 0 comments
Open

ACCL buffers don't support Vitis sw_emu #56

Mellich opened this issue May 19, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Mellich
Copy link
Contributor

Mellich commented May 19, 2022

Using the XRT driver to create an ACCL buffer for simulation, all create_buffer calls except the one that takes an xrt::bo will create a SimBuffer object that returns a nullptr in the SimBuffer::bo() call.

This becomes a problem, if the buffers created with this call should also be used in a user kernel emulated with Vitis sw_emu.
In this case, an invalid address (nullptr) will be passed to the user kernel and lead to undefined behavior. However, in hardware execution, the same code would work, because another buffer class is used underneath.

This is rather an inconsistency than a bug.

@Mellich Mellich added the bug Something isn't working label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant