-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error reading fwupd appinfo #32
Comments
This likely won't break fwupd, but it's a bug regardless of that - the firmware components won't be in the cache because of this, which is really bad. |
The is_valid function should only do minimal validation of the values of an AppStream component, and having an installation candidate is no prerequisite for being valid anymore. (But an id, name and summary are always required, no matter what the component type is) This is the first piece needed for resolving #32
…ng it This is the second part needed before #32 can be resolved.
This ensures we know about all data and can merge components properly if required, before validating them. This means we now allow the parsers to throw out invalid components by default, and it is the callers responsibility now to check for validity. Another step towards fixing #32
Crap, this actually does break things severely - not the fwupd stuff, but if things are loaded in the wrong order, this will severely break the components pool itself, due to GNOME Software placing invalid metadata in |
I am not sure if the way GNOME Software places invalid data in the distro metadata directory is actually a sane thing... Especially because this hijacks the global AppStream namespace and injects new metadata (in this case, the non-standard "featured" category), which will then be available to all software centers (which might want to define their own "featured" apps, e.g. KDE Discover might want to feature its own apps). At least we don't fail hard on these stub metadata entries now and can - relatively reliably - filter them out and merge them. This ŕesolves #32
This issue should be solved now - can you please test with Git master if that is the case for you too? Also, I will make an AppStream release this week, or next Monday (next Monday would be a bit more likely atm, I want some more testing of the changes). |
Hi ximion! Hope you got back okay
fwupd's appinfo can't be read by appstream currently. In sid (install
fwupd
andappstream
, thenapt-get update
):If you delete the first component then the warning just moves to the next one.
I assume this is going to break firmware updates?
The text was updated successfully, but these errors were encountered: