Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppStream::Pool::load() returns false on some systems #97

Closed
aleixpol opened this issue Dec 30, 2016 · 1 comment
Closed

AppStream::Pool::load() returns false on some systems #97

aleixpol opened this issue Dec 30, 2016 · 1 comment

Comments

@aleixpol
Copy link
Collaborator

At least OpenSuse, Neon and Kubuntu (with PPAs).

Reference: https://bugs.kde.org/show_bug.cgi?id=374279

@ximion
Copy link
Owner

ximion commented Jan 5, 2017

That is expected behavior, it will return TRUE only if all data was loaded, if only one bit of data was ignored, FALSE is returned.
To check if there was a bigger error, the function will set a GError - we should expose the error message too on the Qt bindings (add a lastError QString property? or do something more fancy?).

Changing the meaning of the load() return value could break things, doing so would only make sense with some prior announcement (it would at least break appstreamcli, which uses it to show a warning message (but no hard failure) if data wasn't loaded. The function returning false is usually a hint for more experienced users to search for issues, non-technically advanced users should ignore it, since the issues is almost always in upstream software or an issue with the distributor)

aleixpol added a commit to aleixpol/appstream that referenced this issue Jan 11, 2017
As discussed in the issue ximion#97, there's some systems where appstream is
reporting that it doesn't load properly but the users on the platform
don't have information on how to fix it.
With this warning, they will at least have a chance to know.
aleixpol added a commit to aleixpol/appstream that referenced this issue Jan 16, 2017
As discussed in the issue ximion#97, there's some systems where appstream is
reporting that it doesn't load properly but the users on the platform
don't have information on how to fix it.
Provide a warning for frontends to display, giving indications on what's
the problem.
ximion pushed a commit that referenced this issue Jan 19, 2017
As discussed in the issue #97, there's some systems where appstream is
reporting that it doesn't load properly but the users on the platform
don't have information on how to fix it.
Provide a warning for frontends to display, giving indications on what's
the problem.
@ximion ximion closed this as completed Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants