data: Add ‘Endless’ to the list of desktops #522
Conversation
|
I’ve also proposed it here for the XDG menu spec. |
I was about to ask that wile reading the original description 😆 |
appstream-util comes from libappstream-glib, which is outdated and unmaintained. appstreamcli is the more modern replacement, and it comes from libappstream. It implements more up to date validation rules, in particular it has raised the maximum length of screenshot captions from 50 characters to a more manageable 100 characters. The downside is that it more strictly validates `<compulsory_for_desktop>`, and rejects ‘endless’ because it’s not officially registered as a desktop ID. Work around that for now by temporarily removing that element from the XML during validation. In the long term, we need to register the ID: ximion/appstream#522. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
Yes, it is intentional, as I’ve just asked internally, however, about whether we should consider changing the capitalisation now (before it’s standardised) to neaten things up. Please hold! |
appstream-util comes from libappstream-glib, which is outdated and unmaintained. appstreamcli is the more modern replacement, and it comes from libappstream. It implements more up to date validation rules, in particular it has raised the maximum length of screenshot captions from 50 characters to a more manageable 100 characters. The downside is that it more strictly validates `<compulsory_for_desktop>`, and rejects ‘endless’ because it’s not officially registered as a desktop ID. Work around that for now by temporarily removing that element from the XML during validation. In the long term, we need to register the ID: ximion/appstream#522. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk> Fixes: #34
Okay, just tell me when it's ready :-) This patch is otherwise fine obviously, so I can merge it as soon as you're fine with it :-) |
FTR, it's fine with me, it's just that this is the only entry that doesn't start with a capital letter, so it looks a bit like a mistake in the list ^^ |
We're switching it to capitalized |
It’s used to identify Endless OS desktops, which use a modified version of GNOME. It’s always used alongside GNOME (i.e. `DesktopNames=Endless:GNOME`), but is useful as a separate identifier to allow distinguishing between modified Endless OS desktops and stock GNOME. It’s defined in `/usr/share/wayland-sessions/endless-wayland.desktop` on Endless OS systems. That file is provided by the `gnome-session` package whose Debian packaging data is modified during packaging. (i.e. There’s no git repository I can point you to which defines the `Endless` desktop ID.) Defining the desktop allows metainfo files which specify, for example, `<compulsory_for_desktop>Endless</compulsory_for_desktop>` to pass validation. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
pwithnall
force-pushed
the
endless-desktop
branch
from
0bad3c0
to
7e2b6c7
Compare
pwithnall
changed the title
|
I’ve updated the patch to use the new capitalisation. From my point of view it’s ready to merge. Thanks! |
|
Nice, I have no objections :-) |
See https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/73 and ximion/appstream#522. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
appstream-util comes from libappstream-glib, which is outdated and unmaintained. appstreamcli is the more modern replacement, and it comes from libappstream. It implements more up to date validation rules, in particular it has raised the maximum length of screenshot captions from 50 characters to a more manageable 100 characters. The downside is that it more strictly validates `<compulsory_for_desktop>`, and rejects ‘endless’ because it’s not officially registered as a desktop ID. Work around that for now by temporarily removing that element from the XML during validation. In the long term, we need to register the ID: ximion/appstream#522. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk> Fixes: endlessm/endless-key-flatpak#34
appstream-util comes from libappstream-glib, which is outdated and unmaintained. appstreamcli is the more modern replacement, and it comes from libappstream. It implements more up to date validation rules, in particular it has raised the maximum length of screenshot captions from 50 characters to a more manageable 100 characters. The downside is that it more strictly validates `<compulsory_for_desktop>`, and rejects ‘endless’ because it’s not officially registered as a desktop ID. Work around that for now by temporarily removing that element from the XML during validation. In the long term, we need to register the ID: ximion/appstream#522. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk> Fixes: endlessm/endless-key-flatpak#34
It’s used to identify Endless OS desktops, which use a modified version of GNOME.
It’s always used alongside GNOME (i.e.
DesktopNames=endless:GNOME), but is useful as a separate identifier to allow distinguishing between modified Endless OS desktops and stock GNOME.It’s defined in
/usr/share/wayland-sessions/endless-wayland.desktopon Endless OS systems. That file is provided by thegnome-sessionpackage whose Debian packaging data is modified during packaging. (i.e. There’s no git repository I can point you to which defines theendlessdesktop ID.)Defining the desktop allows metainfo files which specify, for example,
<compulsory_for_desktop>endless</compulsory_for_desktop>to pass validation.