Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metainfo validation #34

Closed
dbnicholson opened this issue Sep 7, 2023 · 1 comment
Closed

Fix metainfo validation #34

dbnicholson opened this issue Sep 7, 2023 · 1 comment
Assignees

Comments

@dbnicholson
Copy link
Member

Currently the metainfo validation is failing as in this build:

>>> MALLOC_PERTURB_=85 /usr/bin/appstream-util validate --nonet data/metainfo/org.endlessos.Key.Devel.metainfo.xml
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stdout:
data/metainfo/org.endlessos.Key.Devel.metainfo.xml: FAILED:
• style-invalid         : <caption> is too long [Bring equity into the classroom; curated learning anywhere, anytime with Endless Key];longest allowed is 50 chars
• style-invalid         : <caption> is too long [Completely free; access without an account, safeguarded data, no ads, and no third-party involvement.];longest allowed is 50 chars
• style-invalid         : <caption> cannot end in '.' [Completely free; access without an account, safeguarded data, no ads, and no third-party involvement.]
• style-invalid         : <caption> is too long [Engaging and interactive; discover an abundance of ready-made resources, interactive games, simulations, and a vast ocean of curated content.];longest allowed is 50 chars
• style-invalid         : <caption> cannot end in '.' [Engaging and interactive; discover an abundance of ready-made resources, interactive games, simulations, and a vast ocean of curated content.]
• style-invalid         : <caption> is too long [Grades 5–9, 2700+ curated resources, 1500+ videos, 300+ e-books];longest allowed is 50 chars
• style-invalid         : <caption> is too long [Resources such as finance, healthy body, TED Ed, sports, games, arts & crafts, gardening, and more];longest allowed is 50 chars
• style-invalid         : <caption> is too long [Works online and offline; access learning resources for coding, STEM, cooking, and arts & crafts! Videos, games, and activities included. No Internet required!];longest allowed is 50 chars
stderr:
Validation of files failed

@pwithnall said he was looking at metainfo validation, which I presume means changing from appstream-util to appstreamcli. So, it's possible the validation errors will go away or be different. However, if the above points are valid, then we'll need some new wording. CC @cassidyjames.

@dbnicholson
Copy link
Member Author

See #33.

pwithnall added a commit that referenced this issue Sep 7, 2023
This placates the `appstreamcli` validator. See the following commit.

Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>

Helps: #34
@pwithnall pwithnall self-assigned this Sep 7, 2023
dylanmccall pushed a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
appstream-util comes from libappstream-glib, which is outdated and
unmaintained. appstreamcli is the more modern replacement, and it comes
from libappstream.

It implements more up to date validation rules, in particular it has
raised the maximum length of screenshot captions from 50 characters to a
more manageable 100 characters.

The downside is that it more strictly validates
`<compulsory_for_desktop>`, and rejects ‘endless’ because it’s not
officially registered as a desktop ID. Work around that for now by
temporarily removing that element from the XML during validation. In the
long term, we need to register the ID:
ximion/appstream#522.

Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>

Fixes: endlessm/endless-key-flatpak#34
dylanmccall pushed a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
appstream-util comes from libappstream-glib, which is outdated and
unmaintained. appstreamcli is the more modern replacement, and it comes
from libappstream.

It implements more up to date validation rules, in particular it has
raised the maximum length of screenshot captions from 50 characters to a
more manageable 100 characters.

The downside is that it more strictly validates
`<compulsory_for_desktop>`, and rejects ‘endless’ because it’s not
officially registered as a desktop ID. Work around that for now by
temporarily removing that element from the XML during validation. In the
long term, we need to register the ID:
ximion/appstream#522.

Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>

Fixes: endlessm/endless-key-flatpak#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants