-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metainfo validation #34
Comments
See #33. |
pwithnall
added a commit
that referenced
this issue
Sep 7, 2023
This placates the `appstreamcli` validator. See the following commit. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk> Helps: #34
dylanmccall
pushed a commit
to learningequality/kolibri-installer-gnome
that referenced
this issue
Apr 24, 2024
appstream-util comes from libappstream-glib, which is outdated and unmaintained. appstreamcli is the more modern replacement, and it comes from libappstream. It implements more up to date validation rules, in particular it has raised the maximum length of screenshot captions from 50 characters to a more manageable 100 characters. The downside is that it more strictly validates `<compulsory_for_desktop>`, and rejects ‘endless’ because it’s not officially registered as a desktop ID. Work around that for now by temporarily removing that element from the XML during validation. In the long term, we need to register the ID: ximion/appstream#522. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk> Fixes: endlessm/endless-key-flatpak#34
dylanmccall
pushed a commit
to learningequality/kolibri-installer-gnome
that referenced
this issue
May 4, 2024
appstream-util comes from libappstream-glib, which is outdated and unmaintained. appstreamcli is the more modern replacement, and it comes from libappstream. It implements more up to date validation rules, in particular it has raised the maximum length of screenshot captions from 50 characters to a more manageable 100 characters. The downside is that it more strictly validates `<compulsory_for_desktop>`, and rejects ‘endless’ because it’s not officially registered as a desktop ID. Work around that for now by temporarily removing that element from the XML during validation. In the long term, we need to register the ID: ximion/appstream#522. Signed-off-by: Philip Withnall <philip@tecnocode.co.uk> Fixes: endlessm/endless-key-flatpak#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the metainfo validation is failing as in this build:
@pwithnall said he was looking at metainfo validation, which I presume means changing from
appstream-util
toappstreamcli
. So, it's possible the validation errors will go away or be different. However, if the above points are valid, then we'll need some new wording. CC @cassidyjames.The text was updated successfully, but these errors were encountered: