Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent passing Frames with the wrong dimensions and/or chroma sampling #2461

Open
lu-zero opened this issue Jul 20, 2020 · 1 comment
Open

Prevent passing Frames with the wrong dimensions and/or chroma sampling #2461

lu-zero opened this issue Jul 20, 2020 · 1 comment
Labels
enhancement

Comments

@lu-zero
Copy link
Collaborator

lu-zero commented Jul 20, 2020

As in the code snippet from #2460 we do not validate that the frame provided has the correct dimensions since we assume the user uses Context::new_frame() to create a new frame with the correct settings.

In order to add validation we either need to store the configuration in the Frame.
@Urhengulas
Copy link
Contributor

I'd like to take this on, also because I'd like access to the configuration for the jsapi.

@Urhengulas Urhengulas mentioned this issue Jul 27, 2020
Closed
@Urhengulas Urhengulas self-assigned this Jul 27, 2020
lu-zero added a commit to rust-av/rav1e that referenced this issue Jul 27, 2020
@lu-zero
Remove rav1e::Frame::new()
1b9bdd2 
It is a big footgun (xiph#2461) and should be avoided.
lu-zero added a commit to rust-av/rav1e that referenced this issue Jul 27, 2020
@lu-zero
Remove rav1e::Frame::new()
13c26b1 
It is a big footgun (xiph#2461) and should be avoided.
@lu-zero lu-zero mentioned this issue Jul 27, 2020
Closed
lu-zero added a commit to rust-av/rav1e that referenced this issue Jul 27, 2020
@lu-zero
Remove rav1e::Frame::new()
87c8e37 
It is a big footgun (xiph#2461) and should be avoided.
lu-zero added a commit to rust-av/rav1e that referenced this issue Jul 27, 2020
@lu-zero
Remove rav1e::Frame::new()
6c64003 
It is a big footgun (xiph#2461) and should be avoided.
lu-zero added a commit that referenced this issue Jul 28, 2020
@lu-zero
Remove rav1e::Frame::new()
116c9c7 
It is a big footgun (#2461) and should be avoided.
@Urhengulas Urhengulas removed their assignment Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v_frame: Introduce frame::FrameConfig Urhengulas/rav1e
2 participants
@lu-zero @Urhengulas