Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata OBUs being written without trailing bits #977

Closed
jamrial opened this issue Feb 9, 2019 · 0 comments
Closed

Metadata OBUs being written without trailing bits #977

jamrial opened this issue Feb 9, 2019 · 0 comments
Assignees

Comments

@jamrial
Copy link
Contributor

jamrial commented Feb 9, 2019

An encoding like rav1e INPUT --mastering_display "G(0.1,0.2)B(0.3,0.4)R(0.5,0.6)WP(0.7,0.8)L(2,1)" --output OUTPUT results in the Mastering Display metadata OBU missing the trailing one bit, plus any potentially required trailing zero bits to align to the next byte.

The spec in https://aomediacodec.github.io/av1-spec/#general-obu-syntax states that any OBU type except Temporal Delimiter, Tile Group, Tile List and Frame must include the trailing bits.

@shssoichiro shssoichiro added the bug label Feb 9, 2019
kodawah added a commit to kodawah/rav1e that referenced this issue Feb 13, 2019
Adjust ObuMetaType.size() to return the payload size only.
Fix xiph#977.
kodawah added a commit to kodawah/rav1e that referenced this issue Feb 13, 2019
Adjust ObuMetaType.size() to return the payload size only.
Fix xiph#977.
kodawah added a commit that referenced this issue Feb 13, 2019
Adjust ObuMetaType.size() to return the payload size only.
Fix #977.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants