Further flush fixes #1178

lu-zero · 2019-04-03T22:44:32Z

This should hopefully fix #1081 and make the API a bit simpler.

And remove the inner flush() since it is unused.

Avoid an infiniloop.

And adapt the code accordingly.

Fixes another infiniloop.

coveralls · 2019-04-03T23:21:51Z

Coverage decreased (-0.01%) to 82.849% when pulling 07a84a2 on rust-av:further-flush-fixes into 3a2e8ca on xiph:master.

shssoichiro · 2019-04-04T14:58:28Z

Good stuff, this does seem to fix the issue based on the test file from #1081.

ycho · 2019-04-04T18:13:44Z

@SmilingWolf, Hey- just wanted to let you know that fix has landed for #1081 .

lu-zero added 4 commits April 4, 2019 00:39

Do not increment the the frame_count on flush

a15e80e

And remove the inner flush() since it is unused.

Make sure frame invariant refer to frames already enqueued

fb0b58a

Avoid an infiniloop.

Simplify the EncoderStatus

3c92dec

And adapt the code accordingly.

Be aware of the frame limit in next_keyframe()

07a84a2

Fixes another infiniloop.

tdaede requested a review from shssoichiro April 3, 2019 23:57

tdaede approved these changes Apr 3, 2019

View reviewed changes

lu-zero merged commit 74edd38 into xiph:master Apr 4, 2019

lu-zero deleted the further-flush-fixes branch April 4, 2019 07:17

lu-zero added this to Done in Threaded encoding Apr 16, 2019

Provide feedback