Refactor the binary tests

[Urhengulas]

This PR applies various refactoring to tests/binary.rs:

• add

  fn get_common_cmd(outfile: &str) -> Command

• combine related arguments in Command.args(&[arg1, arg2])
• refactor fn get_tempfile_path(extension: &str) to return OsString
• don't store Command in intermediate variable

Fixes #2337

[coveralls]

Coverage remained the same at 82.195% when pulling a52ed12 on Urhengulas:2337-refactor-the-binary-tests into 5ee1e71 on xiph:master.

[lu-zero]

Thank you for your pull request, I already commented few functional issues, here the annoying non-functional nits :)

• Faktor -> Refactor, Factor in/Factor out
• Do not put the issue number in the PR title, it does not autolink, put it in the body or, even better, put in the commit message body as Fixes #2337.

Thank you a lot :)

[Urhengulas]

Thanks for the review 👍

functional

I added my reasoning to your comments.

non-functional

I normally add the Fixes #... in the commit message, if the fix is only 1 commit. If the fix consists of multiple commits I am always not sure in which commit to put it. 🙈

But, since I have the Fixes #... in the body of the PR it should be fine, right?

[lu-zero]

Thanks for the review 👍

functional

I added my reasoning to your comments.

non-functional

I normally add the Fixes #... in the commit message, if the fix is only 1 commit. If the fix consists of multiple commits I am always not sure in which commit to put it. 🙈

But, since I have the Fixes #... in the body of the PR it should be fine, right?

It is fine.

[lu-zero]

It is more readable to use arg().arg() instead.

[Urhengulas]

That's true.

[Urhengulas]

@lu-zero I dropped the two commits. Should be fine now.

[lu-zero]

Looks good, please rebase the set.