Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add installation instructions for nasm on mac #2442

Merged
merged 1 commit into from
Jul 22, 2020
Merged

doc: Add installation instructions for nasm on mac #2442

merged 1 commit into from
Jul 22, 2020

Conversation

Urhengulas
Copy link
Contributor

No description provided.

@Urhengulas Urhengulas self-assigned this Jul 11, 2020
lu-zero
lu-zero approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, use the right name though.

README.md Outdated Show resolved Hide resolved
vibhoothi
vibhoothi approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@vibhoothi vibhoothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once #2443 lands, you should be rebasing and then we can be land this

vibhoothi
vibhoothi reviewed Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@vibhoothi vibhoothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update this to have NASM 2.15 instructions too

@barrbrain
Copy link
Collaborator

NASM 2.15.02 is the current version in Homebrew. These simple instructions are good for now.

$ brew install nasm
==> Downloading https://homebrew.bintray.com/bottles/nasm-2.15.02.catalina.bottle.tar.gz

@Urhengulas
Copy link
Contributor Author

Urhengulas commented Jul 16, 2020 •
edited

@vibhoothiiaanand: Can you please update this to have NASM 2.15 instructions too

You mean for macOs or also other platforms?

@vibhoothi
Copy link
Collaborator

@vibhoothiiaanand: Can you please update this to have NASM 2.15 instructions too

You mean for macOs or also other platforms?

Yes, so we do not need another patchset,
Referring to the IRC chat after NASM CI update

@lu-zero lu-zero changed the title doc: Add installtion instructions for nasm on mac doc: Add installation instructions for nasm on mac Jul 18, 2020
@lu-zero
Copy link
Collaborator

lu-zero commented Jul 18, 2020

You should rebase it and while at it remove the typo :)

@coveralls
Copy link
Collaborator

coveralls commented Jul 20, 2020 •
edited

Coverage Status

Coverage decreased (-1.5%) to 80.314% when pulling 76c3c8e on Urhengulas:doc-nasm-mac into bea1bde on xiph:master.

@Urhengulas
doc: Update "Dependency: NASM"
76c3c8e 
Changes:
* add installation instructions for nasm on mac
* add info about nasm version the CI is testing against
* update nasm version on windows to 2.15.02
@lu-zero lu-zero merged commit bec32a5 into xiph:master Jul 22, 2020
@Urhengulas Urhengulas deleted the doc-nasm-mac branch August 5, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero approved these changes

@vibhoothi vibhoothi vibhoothi approved these changes

Assignees

@Urhengulas Urhengulas

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Urhengulas @barrbrain @vibhoothi @lu-zero @coveralls