rav1e_js: Various small changes #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `encoder`
* Pass `EncoderConfig` as ref to constructor
--> This enables still using the config afterwards
* Rename [FrameEncoder, VideoEncoder]::fromEncoderConfig(...) to ::new(...)
--> doesn't change anything from js user perspective
* Rm `::default()` from `FrameEncoder`, `VideoEncoder`
--> get default config via `new Encoder(new EncoderConfig())`
* `mod`: `pub use encoder::VideoEncoder`
* `tests`: Clean `utils::simple_encoding`
--> Make test output less verbose
* bump version to `0.3.0`
Urhengulas
force-pushed
the
jsapi-small-changes
branch
from
07fbe16
to
01c9b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
encoderEncoderConfigas ref to constructor--> This enables still using the config afterwards
--> doesn't change anything from js user perspective
::default()fromFrameEncoder,VideoEncoder--> get default config via
new Encoder(new EncoderConfig())mod:pub use encoder::VideoEncodertests: Cleanutils::simple_encoding--> Make test output less verbose
0.3.0