Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on width or height of 1 #2644

Merged
merged 1 commit into from Jan 20, 2021
Merged

Fix crash on width or height of 1 #2644

merged 1 commit into from Jan 20, 2021

Conversation

barrbrain
Copy link
Collaborator

Zero bits were incorrectly chosen to encode a dimension of 1; enforce a minimum of 1 bit per dimension.
Dimensions smaller than 16 are only admitted for still_picture. Add encode-decode tests for these tiny images.

@coveralls
Copy link
Collaborator

coveralls commented Jan 20, 2021

Coverage Status

Coverage decreased (-0.5%) to 65.608% when pulling eab1cd6 on barrbrain:fix-1x1 into b03c614 on xiph:master.

src/header.rs Outdated Show resolved Hide resolved
Zero bits were incorrectly chosen to encode a dimension of 1;
enforce a minimum of 1 bit per dimension.

Dimensions smaller than 16 are only admitted for still_picture.
Add encode-decode tests for these tiny images.
@barrbrain barrbrain merged commit eab1cd6 into xiph:master Jan 20, 2021
@barrbrain barrbrain deleted the fix-1x1 branch January 20, 2021 18:01
@barrbrain barrbrain added this to Done in Release 0.5 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.5
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants