cdef: enforce 8 element size for first_max_element #2807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatth
force-pushed
the
single-element-max-test
branch
from
1f796d6
to
c7c9a5c
Compare
|
I think it would be better to just enforce that the function can only be called on 8-element lists by just taking a |
tmatth
force-pushed
the
single-element-max-test
branch
from
c7c9a5c
to
2939576
Compare
tmatth
changed the title
|
Btw my PR (#2806) also already does this, and also updates the doc comment |
Ah ok will close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed currently as cost is always 8 elements long but will guard againstunexpected breakage should the function be used on single element lists in the future.