Pad input frames in C API and binaries #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zero
reviewed
Oct 7, 2021
|
AWCY results at speed 5 on objective-1-fast are more encouraging:
|
barrbrain
force-pushed
the
issue-2823
branch
3 times, most recently
from
e45908b
to
7ee42b2
Compare
|
I'm convinced mainly by the objective-1-fast results that this is the current best approach. |
lu-zero
approved these changes
Oct 9, 2021
barrbrain
commented
Oct 9, 2021
barrbrain
force-pushed
the
issue-2823
branch
3 times, most recently
from
5b183a2
to
fd242e7
Compare
Document the padding issue in the Rust API.
Assume input frame is padded in residual calculation.
Fix chroma residual crop for odd dimensions.
AWCY results for subset1 at default speed:
PSNR Y | PSNR Cb | PSNR Cr | CIEDE2000 | SSIM | MS-SSIM
0.0646 | -0.0875 | -0.1428 | -0.0024 | 0.1555 | 0.1904
PSNR-HVS Y | PSNR-HVS Cb | PSNR-HVS Cr | PSNR-HVS | VMAF | VMAF-NEG
0.1049 | 0.1927 | -0.0311 | 0.1071 | 0.1522 | 0.1444
Small regressions in frame-level metrics are balanced by a large
improvement in uniformity of error distribution near the boundary.
At the extreme edge, we see a 19.3% reduction in relative error.
Over the 8 pixel wide region at the boundary, we see an average
reduction of 5.3%.
Results at speed 5 on objective-1-fast are more encouraging:
PSNR Y | PSNR Cb | PSNR Cr | CIEDE2000 | SSIM | MS-SSIM
-0.0241 | -0.0949 | -0.1844 | -0.0700 | 0.1164 | 0.1265
PSNR-HVS Y | PSNR-HVS Cb | PSNR-HVS Cr | PSNR-HVS | VMAF | VMAF-NEG
-0.0187 | 0.0020 | -0.0707 | -0.0159 | 0.0142 | 0.0073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2823.
Small regressions in frame-level metrics are balanced by a large improvement in uniformity of error distribution near the boundary. At the extreme, we see a 19.3% reduction in relative error. Over the 8 pixel wide region at the boundary, we see an average reduction of 5.3%.