Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a broken hawktracer annotation #2910

Merged
merged 1 commit into from Apr 24, 2022

Conversation

shssoichiro
Copy link
Collaborator

Some change seems to have occurred which causes this specific hawktracer
annotation to fail to compile. For the time being, remove it so that
hawktracer support can compile again.

@lu-zero
Copy link
Collaborator

lu-zero commented Mar 17, 2022

What is the error?

@shssoichiro
Copy link
Collaborator Author

error[E0501]: cannot borrow `self` as immutable because previous closure requires unique access
   --> /home/runner/.cargo/git/checkouts/rav1e-14e16d25dd5cd9c0/de97f3b/src/scenechange/mod.rs:440:3
    |
440 |   #[hawktracer(cost_scenecut)]
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |   |
    |   second borrow occurs here
    |   closure construction occurs here
    |   borrows occur due to use of `self` in closure
    |   first borrow later used by call
    |
    = note: this error originates in the attribute macro `hawktracer` (in Nightly builds, run with -Z macro-backtrace for more info)
    ```

Some change seems to have occurred which causes this specific hawktracer
annotation to fail to compile. For the time being, remove it so that
hawktracer support can compile again.
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it.

@shssoichiro
Copy link
Collaborator Author

I wish there was a fix for it instead, but I think the issue is related to the fact that we use &mut self inside of the different threads in that function. So I think the only way to keep this annotation would be to completely rewrite how we thread things in this function, which probably requires reducing the threading effectiveness.

@shssoichiro shssoichiro merged commit 4ddc300 into xiph:master Apr 24, 2022
@shssoichiro shssoichiro deleted the remove-broken-hawktrace branch April 24, 2022 16:37
@barrbrain barrbrain added this to Done in Release 0.6 Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants