Add a mock around rayon for disabling threading #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling becomes considerably more difficult to read when rayon is involved, because rayon nests many layers of function calls which obscure where CPU and memory usage is actually occurring. This uses the maybe-rayon crate as a wrapper around rayon, which by default passes through to rayon with zero overhead, but by disabling the "threading" feature in rav1e, the maybe-rayon crate will become a mock which calls functions serially.
shssoichiro
force-pushed
the
maybe-rayon
branch
from
ce313f2
to
a77f844
Compare
kleisauke
added a commit
to kleisauke/rav1e
that referenced
this pull request
May 20, 2023
This is now part of the maybe-rayon crate introduced in PR xiph#2914.
barrbrain
pushed a commit
that referenced
this pull request
May 20, 2023
This is now part of the maybe-rayon crate introduced in PR #2914.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling becomes considerably more difficult to read when rayon is
involved, because rayon nests many layers of function calls which
obscure where CPU and memory usage is actually occurring. This uses the
maybe-rayon crate as a wrapper around rayon, which by default passes
through to rayon with zero overhead, but by disabling the "threading"
feature in rav1e, the maybe-rayon crate will become a mock which calls
functions serially.
Examples:
Memory flamegraph with rayon:
Memory flamegraph without rayon:
