Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retune constants for ssim_boost #2974

Merged
merged 1 commit into from Aug 6, 2022
Merged

Conversation

barrbrain
Copy link
Collaborator

@barrbrain barrbrain commented Aug 2, 2022

There are two target properties:

  • When svar == dvar, ssim_boost ~= k / cbrt(svar)
  • The constant k is chosen such that mean(log(ssim_boost)) ~= 0

The value of k derived from subset3 was very near cbrt(2).

AWCY results for objective-1-fast at default speed:

PSNR Y PSNR Cb PSNR Cr CIEDE2000 SSIM MS-SSIM PSNR-HVS Y PSNR-HVS Cb PSNR-HVS Cr PSNR-HVS VMAF VMAF-NEG
0.0814 1.3359 1.4880 0.3151 -0.6091 -0.6798 -0.1721 1.2087 1.4406 -0.0515 -0.0085 0.0551

AWCY results for subset1 at default speed:

PSNR Y PSNR Cb PSNR Cr CIEDE2000 SSIM MS-SSIM PSNR-HVS Y PSNR-HVS Cb PSNR-HVS Cr PSNR-HVS VMAF VMAF-NEG
1.2789 N/A 0.9796 0.5621 -1.2553 -0.8473 0.2066 N/A N/A 0.2358 1.5926 1.5765

@shssoichiro
Copy link
Collaborator

This looks cool! My only concern is that it increases the filesize by about 10% on average. Is there anything we can do about that without negating the quality improvements?

@coveralls
Copy link
Collaborator

coveralls commented Aug 2, 2022

Coverage Status

Coverage increased (+0.2%) to 85.269% when pulling 4f61531 on barrbrain:ssim-boost-icbrt into cd25677 on xiph:master.

@barrbrain
Copy link
Collaborator Author

barrbrain commented Aug 2, 2022

AWCY results for subset1 in combination with segmentation changes:

PSNR Y PSNR Cb PSNR Cr CIEDE2000 SSIM MS-SSIM PSNR-HVS Y PSNR-HVS Cb PSNR-HVS Cr PSNR-HVS VMAF VMAF-NEG
2.1613 1.5164 1.9015 0.4371 -2.8940 -2.2272 0.5407 0.5901 0.5884 0.6090 1.9500 2.0070

For still frames, there is no net change in average file size compared to the baseline before segmentation rework.
We still need some work on tuning the temporal part of RDO.

@barrbrain barrbrain force-pushed the ssim-boost-icbrt branch 2 times, most recently from dde6ccb to 3ace4e5 Compare August 5, 2022 19:38
There are two target properties:
* When svar == dvar, ssim_boost ~= k / cbrt(svar)
* The constant k is chosen such that mean(log(ssim_boost)) ~= 0

The value of k derived from subset3 was very near cbrt(2).

AWCY results for objective-1-fast at default speed:

PSNR Y | PSNR Cb | PSNR Cr | CIEDE2000 |    SSIM | MS-SSIM
0.0814 |  1.3359 |  1.4880 |    0.3151 | -0.6091 | -0.6798

PSNR-HVS Y | PSNR-HVS Cb | PSNR-HVS Cr | PSNR-HVS |    VMAF | VMAF-NEG
   -0.1721 |      1.2087 |      1.4406 |  -0.0515 | -0.0085 |   0.0551

AWCY results for subset1 at default speed:

PSNR Y | PSNR Cb | PSNR Cr | CIEDE2000 |    SSIM | MS-SSIM
1.2789 |     N/A |  0.9796 |    0.5621 | -1.2553 | -0.8473

PSNR-HVS Y | PSNR-HVS Cb | PSNR-HVS Cr | PSNR-HVS |   VMAF | VMAF-NEG
    0.2066 |         N/A |         N/A |   0.2358 | 1.5926 |   1.5765
@barrbrain barrbrain merged commit c402d7a into xiph:master Aug 6, 2022
@barrbrain barrbrain deleted the ssim-boost-icbrt branch August 6, 2022 05:22
@barrbrain barrbrain added this to Done in Release 0.6 Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants