Add AVX2 HBD SATD asm for 8x8-transformed blocks #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 86.41% // Head: 86.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3048 +/- ##
==========================================
- Coverage 86.41% 86.22% -0.19%
==========================================
Files 84 84
Lines 33158 33158
==========================================
- Hits 28652 28591 -61
- Misses 4506 4567 +61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
barrbrain
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little more than 2x faster for 8x8 block size than the current intrinsics code. Relative speedup should be higher for larger block sizes because of lower looping overhead and using a vertical sum for each 8x8 satd, and using 1 horizontal sum at the end instead of doing a horizontal sum for each block, which is much slower.
Might be possible to go faster by recursively splitting each transform into 2 smaller transforms (like a radix-2 FFT), but I figured this is good enough for now.