Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant imports #3354

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

FreezyLemon
Copy link
Contributor

These result in warnings on 1.78 (current nightly). For example:

warning: the item `Pixel` is imported redundantly
  --> src/bin/stats.rs:14:21
   |
10 | use av_metrics::video::*;
   |     -------------------- the item `Pixel` is already imported here
...
14 | use rav1e::{Packet, Pixel};
   |                     ^^^^^

These result in warnings in Rust 1.78
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (3c3a26f) to head (86e6045).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.01%     
==========================================
  Files          89       89              
  Lines       28323    28355      +32     
==========================================
+ Hits        25074    25107      +33     
+ Misses       3249     3248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@barrbrain barrbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are clearly redundant from the local context.

@barrbrain barrbrain merged commit 5eaae62 into xiph:master Feb 26, 2024
25 checks passed
@FreezyLemon FreezyLemon deleted the remove-redundant-imports branch February 26, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants