Fix build on wasm32-unknown-unknown #3367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wasm-pack build --no-default-features -F wasm`
`wasm-pack build --no-default-features` The wasm feature still exists for compatibility but is a no-op.
|
This seems to break fuzzing somehow. I'll take a look and try to fix it |
lu-zero
reviewed
Mar 13, 2024
| @@ -167,6 +173,8 @@ bench = false | |||
|
|
|||
| [lib] | |||
| bench = false | |||
| # cdylib is required for wasm32-unknown-unknown | |||
There was a problem hiding this comment.
This is potentially annoying, rustwasm/wasm-pack#1297 should fix it.
lu-zero
reviewed
Mar 13, 2024
There was a problem hiding this comment.
I'd wait for rustwasm/wasm-pack#1297 to get addressed and/or check if the unreleased wasm-pack doesn't address it otherwise.
I do not consider acceptable to add cdylib unconditionally.
|
I see. wasm-pack's master branch doesn't seem to include any changes that would help work around this problem. Not much to do except wait. I'll close this. When this is fixed in wasm-pack, it should be easy to reimplement. |
|
https://crates.io/crates/trunk might be an alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crate-type = "cdylib"is needed forwasm-packto workwasmfeature, everything can be auto-detected (-F wasmis now a no-op)wasm-bindgenshould only be included forwasm32-unknown-unknown.wasm32-wasidoes not need it. I'm not sure about emscriptenwasm-pack buildand other commands should now work.--no-default-featuresis necessary because thebinariesfeature does not compile on wasm.Note that testing on wasm32-unknown-unknown can't just be done with
cargo testand requires more work. I'll do that in a separate PR (incl. CI).