Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transform: simplify log ratio helper #829

Merged
merged 4 commits into from Dec 30, 2018
Merged

transform: simplify log ratio helper #829

merged 4 commits into from Dec 30, 2018

Conversation

tmatth
Copy link
Member

@tmatth tmatth commented Dec 29, 2018

No description provided.

@tmatth tmatth requested review from ycho and lu-zero December 29, 2018 22:45
@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.007%) to 84.034% when pulling bee602a on simplify-log-ratio into 16ff6cd on master.

@coveralls
Copy link
Collaborator

coveralls commented Dec 29, 2018 •
edited

Coverage Status

Coverage decreased (-0.6%) to 83.466% when pulling 8bb69a3 on simplify-log-ratio into 0488190 on master.

@KyleSiefring
Copy link
Collaborator

-1 Use ilog or msb from util.rs.

@tmatth
Copy link
Member Author

tmatth commented Dec 30, 2018

@KyleSiefring yeah I realized that after pushing ;)

KyleSiefring
KyleSiefring approved these changes Dec 30, 2018
View reviewed changes
Copy link
Collaborator

@KyleSiefring KyleSiefring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tmatth
Copy link
Member Author

tmatth commented Dec 30, 2018 •
edited

Assuming I'm using cargo bench correctly, using msb is faster. Travis bench results between msb() and ilog() version don't seem to differ, so I'll stick with the ilog() version as it's less ugly.

@tmatth
Revert "transform: use msb"
8bb69a3 
This reverts commit c89f558.
lu-zero
lu-zero approved these changes Dec 30, 2018
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I guess you can squash and fold in it anytime :)

ycho
ycho approved these changes Dec 30, 2018
View reviewed changes
Copy link
Collaborator

@ycho ycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@tmatth tmatth merged commit 5c4ed0b into master Dec 30, 2018
@tmatth tmatth deleted the simplify-log-ratio branch December 30, 2018 15:30
@tmatth tmatth self-assigned this Dec 30, 2018
lu-zero pushed a commit to rust-av/rav1e that referenced this pull request Jan 8, 2019
@tmatth @lu-zero
transform: simplify log ratio helper (xiph#829)
9754b40 
* transform: simplify log ratio helper

* transform: add tests for tx log ratios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero approved these changes

@ycho ycho ycho approved these changes

@KyleSiefring KyleSiefring KyleSiefring approved these changes

Assignees

@tmatth tmatth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tmatth @coveralls @KyleSiefring @lu-zero @ycho