build: draw more attention to desync #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatth
force-pushed
the
build/bigger-desync-warning
branch
from
284ad5a
to
b5f514d
Compare
|
Looks like:
I was tempted to output an alert sound too but then I realized that I had disabled them. |
rzumer
approved these changes
Feb 4, 2019
lu-zero
reviewed
Feb 4, 2019
build.sh
Outdated
| @@ -108,7 +108,7 @@ ${AOM_TEST}/aomdec $ENC_FILE -o $DEC_FILE | |||
| # Input/Output compare | |||
| tail -n+2 $DEC_FILE > /tmp/dec_file | |||
| tail -n+2 $REC_FILE > /tmp/rec_file | |||
| cmp /tmp/dec_file /tmp/rec_file | |||
| cmp /tmp/dec_file /tmp/rec_file || printf '\e[1;31m%-6s\e[m\n\n' "Desync detected!!!" && exit 1 | |||
There was a problem hiding this comment.
Suggested change
| cmp /tmp/dec_file /tmp/rec_file || printf '\e[1;31m%-6s\e[m\n\n' "Desync detected!!!" && exit 1 | |
| cmp /tmp/dec_file /tmp/rec_file || printf '\e[1;31m%-6s\e[m\n\n' 'Desync detected!!!' && exit 1 |
the ! could be problematic if you do not single-quote the string
|
works also on the ugly |
tmatth
force-pushed
the
build/bigger-desync-warning
branch
from
b5f514d
to
f021021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.