Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native 中那些令我收获颇丰的痛点 #5145

Conversation

jerryOnlyZRJ
Copy link
Contributor

译文翻译完成,resolve #5087

@leviding leviding added the iOS label Feb 15, 2019
@xilihuasi
Copy link
Contributor

校对认领

@fanyijihua
Copy link
Collaborator

@xilihuasi 好的呢 🍺

Copy link
Contributor

@xilihuasi xilihuasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerryOnlyZRJ 校对完成,翻译的很棒!

@WangLeto
Copy link
Contributor

校对认领

@fanyijihua
Copy link
Collaborator

@WangLeto 妥妥哒 🍻

Copy link
Contributor

@WangLeto WangLeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一处外部链接遗漏,一处错误,部分语病

@WangLeto
Copy link
Contributor

@jerryOnlyZRJ Good job!校对都给我累够呛。
@leviding 你好,完成校对了。

@WangLeto
Copy link
Contributor

对于出现长句没有自动换行的情况我很抱歉!我在 review 的时候没有发现异常,commit 以后在这个页面才意识到有问题。建议检查的时候打开开发者工具审查需要换行的元素,然后在找到的 .markdown-body table td, .markdown-body table th 样式中修改代码:

.markdown-body table td, .markdown-body table th {
    word-break: break-word;
    white-space: normal;
}

这样就可以自动换行了。

@leviding leviding added the enhancement 等待译者修改 label Feb 18, 2019
@swants
Copy link

swants commented Feb 22, 2019

@jerryOnlyZRJ 校对者已经校对完成,请及时根据建议进行调整。

@leviding
Copy link
Member

@jerryOnlyZRJ 抓紧修改啦

@jerryOnlyZRJ
Copy link
Contributor Author

@WangLeto @xilihuasi 已更正

@WangLeto
Copy link
Contributor

👍 (第一次参加校对,自以为是地提了很多修改建议,还望谅解 😂)

@jerryOnlyZRJ
Copy link
Contributor Author

@WangLeto 建议很好,很专业,而且看的出来你很用心

@lsvih lsvih self-assigned this Feb 25, 2019
@lsvih lsvih added 标注 待管理员 Review and removed enhancement 等待译者修改 正在校对 labels Feb 25, 2019
@lsvih lsvih removed their assignment Feb 25, 2019
lsvih
lsvih previously approved these changes Feb 25, 2019
@lsvih
Copy link
Member

lsvih commented Feb 25, 2019

@jerryOnlyZRJ @xilihuasi 提出的问题还有两个没有改,您和他再沟通一下吧?

Copy link

@swants swants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还稍微有些瑕疵,建议再修改下。

@swants
Copy link

swants commented Feb 25, 2019

@jerryOnlyZRJ 不好意思,刚才 approve 的时候发现些小瑕疵,建议修改下。

…but-rewarding-way.md' of https://github.com/jerryOnlyZRJ/gold-miner into translation/things-about-react-native-i-found-the-hard-but-rewarding-way.md
@jerryOnlyZRJ
Copy link
Contributor Author

@swants 已更正

@leviding leviding merged commit 6cbc742 into xitu:master Feb 25, 2019
@leviding
Copy link
Member

@jerryOnlyZRJ 已经 merge 啦~ 快快麻溜发布到掘金然后给我发下链接,方便及时添加积分哟。

掘金翻译计划有自己的知乎专栏,你也可以投稿哈,推荐使用一个好用的插件
专栏地址:https://zhuanlan.zhihu.com/juejinfanyi

@leviding leviding added 翻译完成 and removed 标注 待管理员 Review labels Feb 25, 2019
@jerryOnlyZRJ
Copy link
Contributor Author

@jerryOnlyZRJ jerryOnlyZRJ deleted the translation/things-about-react-native-i-found-the-hard-but-rewarding-way.md branch February 26, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Native 中那些令我收获颇丰的痛点
7 participants