Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow implementation nodes to occur/reoccur in any order in the input #224

Merged
merged 2 commits into from
Nov 28, 2021
Merged

Allow implementation nodes to occur/reoccur in any order in the input #224

merged 2 commits into from
Nov 28, 2021

Conversation

MikeEdgar
Copy link
Member

Fixes #223

@coveralls
Copy link

coveralls commented Nov 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1511663856

  • 19 of 19 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 98.102%
Totals Coverage Status
Change from base Build 1490201241: 0.009%
Covered Lines: 4858
Relevant Lines: 4952
💛 - Coveralls

@MikeEdgar MikeEdgar changed the title Allow implementation nodes to occur/recur in any order in the input Allow implementation nodes to occur/reoccur in any order in the input Nov 28, 2021
@MikeEdgar MikeEdgar force-pushed the 892_relax_impl_node_validation_order branch from 832c597 to a3d71e7 Compare November 28, 2021 01:08
@MikeEdgar MikeEdgar force-pushed the 892_relax_impl_node_validation_order branch from a3d71e7 to 97f39a3 Compare November 28, 2021 01:21
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar merged commit 8702964 into master Nov 28, 2021
@MikeEdgar MikeEdgar deleted the 892_relax_impl_node_validation_order branch November 28, 2021 02:27
@MikeEdgar MikeEdgar added this to the v1.18.2 milestone Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.18.2
Development

Successfully merging this pull request may close these issues.

Implementation loop cursor not properly reset for multiple occurrences
2 participants
@MikeEdgar @coveralls