Jacob/chore update landing image media query #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a media query for screens bigger than 2560px - Sets the background images to a width of 1392px. (xlayers#234)
Make header responsive at screen size bigger than 2560px (xlayers#234)
12 tasks
|
Thank you for your time for this PR. I will review it soon and provide feedback if needed. |
Jefiozie
requested changes
Oct 8, 2019
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
jacobtyq
force-pushed
the
jacob/chore-update_landing_image_media_query
branch
from
82b5ff8
to
710268f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Issue Number: 234
#234
What is the new behaviour?
Add a media query for screen sizes above 2560px
The following elements will be affected
.bg img(width)header img(max-width)Sets a width of 1392px for those two elements.
Does this PR introduce a breaking change?
Other information
Might want to update the image sizes or use responsive images for landing page
https://css-tricks.com/responsive-images-css/