Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): upgrade to Angular V8.3 #332

Merged
merged 1 commit into from Nov 5, 2019

Conversation

kartik-budhiraja
Copy link
Contributor

upgrade core Angular and other dependencies

#327

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #327
Current Angular version ng version:

Screen Shot 2019-10-20 at 5 52 31 PM

What is the new behavior?

Updated Angular version ng version:

Screen Shot 2019-10-20 at 6 07 47 PM

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

upgrade core Angular and other dependencies

xlayers#327
Copy link
Member

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @kartik-budhiraja

src/polyfills.ts Show resolved Hide resolved
@manekinekko
Copy link
Member

Thank you for this PR. I have left a comment before going ahead and merging the PR.

@Jefiozie Jefiozie self-requested a review November 4, 2019 14:15
Copy link
Member

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jefiozie Jefiozie merged commit 558d2d2 into xlayers:master Nov 5, 2019
@kartik-budhiraja kartik-budhiraja deleted the refactor-angular-upgrade branch November 5, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants