Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add keep alive logic for xlinectl lock command #666

Closed

Conversation

Phoenix500526
Copy link
Collaborator

Closes: #664

Please briefly answer these questions:

  1. remove the lease client from LockClient
  2. add keep alive logic for xlinectl lock cmd
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@Phoenix500526 Phoenix500526 force-pushed the fix/xlinectl-lock-issue branch 8 times, most recently from 2f2f4ec to 2369dcb Compare March 1, 2024 13:56
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 75.22%. Comparing base (e35b35a) to head (138250e).
Report is 28 commits behind head on master.

Files Patch % Lines
crates/xlinectl/src/command/lock.rs 0.00% 14 Missing ⚠️
...xline-test-utils/src/bin/validation_lock_client.rs 0.00% 9 Missing ⚠️
crates/xlinectl/src/command/lease/keep_alive.rs 0.00% 6 Missing ⚠️
crates/xline-client/src/clients/lock.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   75.55%   75.22%   -0.34%     
==========================================
  Files         180      182       +2     
  Lines       26938    26990      +52     
  Branches    26938    26990      +52     
==========================================
- Hits        20353    20302      -51     
- Misses       5366     5428      +62     
- Partials     1219     1260      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Closes: xline-kv#664
Signed-off-by: Phoeniix Zhao <Phoenix500526@163.com>
@mergify mergify bot requested a review from a team April 19, 2024 04:35
@Phoenix500526
Copy link
Collaborator Author

Closed since it's duplicated with pr #820

@Phoenix500526 Phoenix500526 deleted the fix/xlinectl-lock-issue branch May 20, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The xlinectl won't renew the lease of the lock key
2 participants