Fix/issue 684

[Phoenix500526]

Please briefly answer these questions:
Close the issue #664 and #684

• what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
  Close the issue [Bug]: The xlinectl won't renew the lease of the lock key #664 and [Refactor]: Add a session structure to renew lock lease automatically  #684

• what changes does this pull request make?
  Implement a session structure to auto renew the lock lease.
  Implement an Xutex, which means Xline Mutex, to describe a lock instance
  Provide an RAII implementation XutexGuard for Xutex
  Remove the LockRequest and UnlockRequest in xline-client
  Remove some unless test cases, like lock_should_timeout_when_ttl_is_set. Actually, whether the ttl is set or not, the lock in etcd won't timeout. The ttl of a lock is only used to liveness checking. FYI: what is used for about ttl in session? etcd-io/etcd#6736
  Remove the validation_lock_client.rs

• are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
  no

[mergify]

@Phoenix500526 Convert your pr to draft since CI failed

[mergify]

@Phoenix500526 You've modified the workflows. Please don't forget to update the .mergify.yml.

[codecov]

Codecov Report

Attention: Patch coverage is 70.04831% with 62 lines in your changes missing coverage. Please review.

Project coverage is 75.57%. Comparing base (e35b35a) to head (09f1df9).
Report is 132 commits behind head on master.

Files	Patch %	Lines
crates/xline-client/src/clients/lock.rs	73.97%	38 Missing and 13 partials ⚠️
crates/xlinectl/src/command/lock.rs	0.00%	6 Missing ⚠️
crates/xlinectl/src/command/lease/keep_alive.rs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   75.55%   75.57%   +0.02%     
==========================================
  Files         180      186       +6     
  Lines       26938    27712     +774     
  Branches    26938    27712     +774     
==========================================
+ Hits        20353    20944     +591     
- Misses       5366     5472     +106     
- Partials     1219     1296      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mergify]

@Phoenix500526 Convert your pr to draft since CI failed

[mergify]

@Phoenix500526 Your PR is in conflict and cannot be merged.

[mergify]

@Phoenix500526 Your PR is in conflict and cannot be merged.

[rogercloud]

Mutex and its guard may be not the best way to abstract. If there's any error happens, such as lease renew failure, lock free is a good point to report error. In the mutex guard abstraction, lock free is in the drop function, which is not possible to handle for the caller.

[mergify]

@Phoenix500526 Convert your pr to draft since CI failed

[mergify]

@Phoenix500526 Your PR is in conflict and cannot be merged.

[mergify]

@Phoenix500526 Convert your pr to draft since CI failed

[bsbds]

We could guarantee the lock safety by coupling the lock key to every update send to Xline, and the Xline server must verify the validity of the key. Please refer to https://jepsen.io/analyses/etcd-3.4.3

On the client side, we could associate KV operation methods to the lock guard to prevent user from using the lock for other purpose.

[Phoenix500526]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[CrystalAnalyst]

LGTM.

[CrystalAnalyst]

LGTM