Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vsxmake #488

Merged
merged 22 commits into from Jul 19, 2019
Merged

Improve vsxmake #488

merged 22 commits into from Jul 19, 2019

Conversation

OpportunityLiu
Copy link
Member

@OpportunityLiu OpportunityLiu commented Jul 16, 2019

@OpportunityLiu
Copy link
Member Author

OpportunityLiu commented Jul 16, 2019

加了个 path.joinenv,测下来大概这个水平,慢了8倍左右
图片

*nix 下和 table.concat 几乎无区别

@OpportunityLiu

This comment has been minimized.

@waruqi
Copy link
Member

waruqi commented Jul 16, 2019

还有,*trim 还是赶紧换C实现吧,太慢了。。 我本来还想把每个输入trim一下,结果一测满了100多倍。。。

别急,你可以开个issues备着吧。。我还在处理 之前的乱码问题呢。。每天时间不多,只能挨个搞。。

@OpportunityLiu
Copy link
Member Author

@waruqi #257 (comment)
这个咋处理?

@waruqi
Copy link
Member

waruqi commented Jul 17, 2019

@waruqi #257 (comment)
这个咋处理?

可以看下

function builder:_add_values_from_targetopts(values, target, name)
for _, opt in ipairs(target:orderopts()) do
table.join2(values, table.wrap(opt:get(name)))
end
end
-- add values from target packages
function builder:_add_values_from_targetpkgs(values, target, name)
for _, pkg in ipairs(target:orderpkgs()) do
-- uses them instead of the builtin configs if exists extra package config
-- e.g. `add_packages("xxx", {links = "xxx"})`
local configinfo = target:pkgconfig(pkg:name())
if configinfo and configinfo[name] then
table.join2(values, configinfo[name])
else
-- uses the builtin package configs
table.join2(values, pkg:get(name))
end
end
end

@OpportunityLiu
Copy link
Member Author

rules不用管了?

@waruqi
Copy link
Member

waruqi commented Jul 17, 2019

rules不用管了?

你是指哪里对rules的处理?

@OpportunityLiu
Copy link
Member Author

这两个不是opt和pkg,之前还有deps,我看order**里还有rules

@waruqi
Copy link
Member

waruqi commented Jul 17, 2019

这两个不是opt和pkg,之前还有deps,我看order**里还有rules

怎么感觉有回到了之前老版本vs插件遇到的问题了么。。?如果只是为了intelliscene和定义跳转,里面大部分设置,在rules里面xx_load里面都已经处理掉了(config检测时候),所以其他情况的rules处理就不要去管了。也支持不了

@OpportunityLiu
Copy link
Member Author

图片
这命令行解析。。。

@OpportunityLiu
Copy link
Member Author

OpportunityLiu commented Jul 18, 2019

图片
可以了

@waruqi
Copy link
Member

waruqi commented Jul 18, 2019

ok,等晚上我细看下。

@waruqi
Copy link
Member

waruqi commented Jul 18, 2019

图片
这命令行解析。。。

这个问题我修掉了

xmake/core/base/path.lua Outdated Show resolved Hide resolved
xmake/core/base/path.lua Outdated Show resolved Hide resolved
xmake/core/base/os.lua Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants