Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incremental compilation for .def files #4901

Closed
wants to merge 1 commit into from

Conversation

star-hengxing
Copy link
Contributor

Fix #4898

@waruqi
Copy link
Member

waruqi commented Mar 30, 2024

这么搞不行,即使 .def 每次都不改,也会重新 link 的

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


This won't work. Even if .def is not changed every time, it will be linked again.

@star-hengxing
Copy link
Contributor Author

没啥思路,也许应该弄一个新 api,给 target 添加依赖文件?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I have no idea. Maybe I should create a new API and add dependency files to the target?

@waruqi
Copy link
Member

waruqi commented Mar 30, 2024

暂时没想到更好的通用接口,暂时用 target:data_add("linkdepfiles", sourcefile) rule 的内部接口配置,后面想办法再改进。

@waruqi waruqi closed this Mar 30, 2024
@star-hengxing star-hengxing deleted the fix-windows-def branch March 30, 2024 15:51
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I haven't thought of a better general interface for the time being. I will use the internal interface configuration of target:data_add("linkdepfiles", sourcefile) rule for the time being, and I will think of ways to improve it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants