runtimes support for package:check_cxxsnippet #4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthapz
force-pushed
the
cxx_snippet_runtimes
branch
from
36774c1
to
92214b5
Compare
waruqi
reviewed
Apr 2, 2024
waruqi
reviewed
Apr 2, 2024
|
The current package-related runtimes settings should be handled here. xmake/xmake/core/package/package.lua Line 2268 in 92214b5 Although there is some hardcoding here, it is less impactful than modifying the builder. Maybe there's a better way to handle this later. More needs to be done to support it well, maybe you can open an issue first. |
waruqi
reviewed
Apr 2, 2024
Arthapz
force-pushed
the
cxx_snippet_runtimes
branch
from
92214b5
to
aa321b0
Compare
Arthapz
force-pushed
the
cxx_snippet_runtimes
branch
from
40c920e
to
5100535
Compare
Arthapz
force-pushed
the
cxx_snippet_runtimes
branch
from
5100535
to
3319219
Compare
|
I haven't had time to review it lately and may have to wait a few more days. |
No problem take ur time |
waruqi
reviewed
Apr 5, 2024
waruqi
reviewed
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support passing runtime flags to check_cxxsnippet, this is a POC just to get ur opinion and suggestions
this is needed because if a package is built with libc++ and linked to a snippet which use libstdc++, this will result in a link error