Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for --runtimes for autoconf, cmake, make and meson packages #4927

Merged
merged 2 commits into from Apr 19, 2024

Conversation

Arthapz
Copy link
Member

@Arthapz Arthapz commented Apr 3, 2024

draft because depends of #4921

@Arthapz Arthapz marked this pull request as draft April 3, 2024 03:20
@Arthapz Arthapz changed the title add support for --runtimes on autoconf, cmake, make and meson buildsystems add support for --runtimes for autoconf, cmake, make and meson packages Apr 3, 2024
@Arthapz Arthapz marked this pull request as ready for review April 8, 2024 13:16
@@ -304,6 +304,16 @@ function buildenvs(package, opt)
table.join2(cxxflags, package:_generate_lto_configs("cxx").cxxflags)
table.join2(ldflags, package:_generate_lto_configs().ldflags)
end
local runtimes = package:config("runtimes")
if runtimes then
local fake_target = {is_shared = function(_) return false end,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not pass package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here. why?

@waruqi waruqi merged commit 09b1a53 into xmake-io:dev Apr 19, 2024
19 checks passed
@waruqi waruqi added this to the v2.9.1 milestone Apr 19, 2024
@waruqi waruqi mentioned this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants