Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More refactoring #92

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

adamnemecek
Copy link
Contributor

Im not sure why it shows all the commits, the real changes start with "trimmed whitespace" (including that one)

@bryant1410
Copy link
Member

Im not sure why it shows all the commits, the real changes start with "trimmed whitespace" (including that one)

I think you need to rebase with master to view it accordingly.

@bryant1410
Copy link
Member

@adamnemecek is this ready to review?

Copy link
Member

@mats-claassen mats-claassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @adamnemecek

@@ -20,7 +20,7 @@ public extension TFOptimizer {
/// This information can later be used by the 'activationNeuron' function
func addNeuronIfThere(node: TFNode) {
let outgoing = node.outgoingNodes()
if outgoing.count == 1, let next = (outgoing.first as? TFNode),
if let next = (outgoing.first as? TFNode),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want to remove this check. There could be more than one outgoingNodes

assert(inputNodes.count == startNodes.count, "Number of network inputs(\(inputNodes.count)) and input sizes(\(startNodes.count)) are not equal")
if inputNodes.count == 1 {
inputNodes[0].addIncomingEdge(from: startNodes[0])
if let first = inputNodes.first {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. If there are many inputNodes we want to go into the else

@bryant1410
Copy link
Member

Hey, we have run the Swiftlint autocorrect and have added it to the CI check. Can you rebase your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants