Fix table view contentInset adjustment with safe area when keyboard shows #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-claassen
approved these changes
Jan 3, 2020
adozenlines
added a commit
to adozenlines/Eureka
that referenced
this pull request
Feb 14, 2020
* master: (21 commits) Remove bundle from podspec (xmartlabs#1981) Version bump 5.2.0 (xmartlabs#1980) Remove bundle resources (reimplemented in code) to support Swift Package Manager (xmartlabs#1976) Fix: avoid reloading rows in viewWillAppear when tableView is not added to window (xmartlabs#1971) Remove InputTypeInitiable constraint for PickerInputRow (xmartlabs#1975) Fix optional header and footer in SelectorViewController. (xmartlabs#1962) Fix table view contentInset adjustment with safe area when keyboard shows (xmartlabs#1960) fix for iOS 13 that was not removing the row automatically anymore even after calling the completion handler in a destructive swipe action (xmartlabs#1944) Add GenericMultivaluedSection to allow changing add button (xmartlabs#1843) Add [unowned self] to fix reference cycle (xmartlabs#1930) Allows a section's header and footer to be `nil` (xmartlabs#1927) version bump 5.1.0 (xmartlabs#1921) Fixed StepperRow for iOS 13 (xmartlabs#1913) Fix Travis for Xcode 11 iPhone 11 setting the property wouldn't work Fixes documentation warning Release v5.0.1 Fixed TextAreaRow Formatter comformance check implemented dark mode (xmartlabs#1889) Fix iPhone name ... # Conflicts: # Example/Example/Base.lproj/Main.storyboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UITableView will adjust it's
contentInsetwith safe area. The adjustedcontentInsetcan be derived fromadjustedContentInsetapi. When table view is influenced by safe area,Eureka 5.1.0has an issue thatcontentInsetis adjusted too much after keyboard shows.Solve #1959 #1953