Update plugin screenshot to : allow insecure https and add details in filename #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1mm0rt41PC
commented
Sep 16, 2020
1mm0rt41PC
commented
- Allow insecure https to avoid bad rendering
- Add the full url ( stripped with bad chars) in the file name
- Change png to jpg in order to reduce the screenshot's size
Bumps [pycurl](https://github.com/pycurl/pycurl) from 7.43.0.5 to 7.43.0.6. - [Release notes](https://github.com/pycurl/pycurl/releases) - [Changelog](https://github.com/pycurl/pycurl/blob/master/ChangeLog) - [Commits](https://github.com/pycurl/pycurl/commits) Signed-off-by: dependabot[bot] <support@github.com>
Bump pycurl from 7.43.0.5 to 7.43.0.6
… filename - Allow insecure https to avoid bad rendering - Add the full url ( stripped with bad chars) in the file name - Change png to jpg in order to reduce the screenshot's size
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 71.43% 71.42% -0.01%
==========================================
Files 93 93
Lines 7204 7205 +1
==========================================
Hits 5146 5146
- Misses 2058 2059 +1
Continue to review full report at Codecov.
|
|
The build is failing due to black and flake formatters, can you please check? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.