Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webpa-common/logging & webpa-common/bascule* & go-kit/log & go-kit/kit/log #203

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Remove webpa-common/logging & webpa-common/bascule* & go-kit/log & go-kit/kit/log #203

wants to merge 13 commits into from

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Oct 12, 2022 •
edited
Loading

@denopink denopink added enhancement webpa-common archival/deprecation work related to the archival & deprecation of webpa-common labels Oct 12, 2022
@denopink denopink self-assigned this Oct 12, 2022
@denopink denopink mentioned this pull request Oct 12, 2022
Open
4 tasks
@guardrails
Copy link

guardrails bot commented Oct 12, 2022 •
edited
Loading

⚠️ We detected 3 security issues in this pull request:

Vulnerable Libraries (3)
Severity Details
High pkg:golang/github.com/gorilla/websocket@v1.5.0@v1.5.0 - no patch available
High pkg:golang/gopkg.in/yaml.v2@v2.4.0@v2.4.0 - no patch available
N/A pkg:golang/github.com/aws/aws-sdk-go@v1.44.126@v1.44.126 - no patch available

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@denopink denopink force-pushed the denopink/refactoring/remove-webpa-common/logging branch from c24a58f to 25e9b2a Compare October 12, 2022 15:45
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@denopink denopink marked this pull request as draft October 17, 2022 14:23
@denopink denopink changed the title Remove webpa-common/logging & go-kit/logging Remove webpa-common/logging & go-kit/log & go-kit/kit/log Oct 19, 2022
@denopink denopink mentioned this pull request Oct 19, 2022
Open
1 task
johnabass
johnabass requested changes Oct 26, 2022
View reviewed changes
basculeLogging.go Outdated Show resolved Hide resolved
basculeLogging.go Outdated Show resolved Hide resolved
@denopink denopink marked this pull request as ready for review October 26, 2022 19:47
@denopink denopink force-pushed the denopink/refactoring/remove-webpa-common/logging branch from daa42aa to 9521c53 Compare October 31, 2022 15:16
@denopink denopink changed the title Remove webpa-common/logging & go-kit/log & go-kit/kit/log Remove webpa-common/logging & webpa-common/bascule* & go-kit/log & go-kit/kit/log Nov 1, 2022
@denopink denopink marked this pull request as draft November 1, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnabass johnabass johnabass approved these changes

@renaz6 renaz6 Awaiting requested review from renaz6

Assignees

@denopink denopink

Labels
enhancement webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
None yet
Milestone
No milestone
2 participants
@denopink @johnabass