-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove webpa-common/logging
& webpa-common/bascule*
& go-kit/log
& go-kit/kit/log
#203
Draft
denopink
wants to merge
13
commits into
main
Choose a base branch
from
denopink/refactoring/remove-webpa-common/logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulnerable Libraries (3)
More info on how to fix Vulnerable Libraries in Go. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
c24a58f
to
25e9b2a
Compare
Kudos, SonarCloud Quality Gate passed! |
webpa-common/logging
& go-kit/logging
webpa-common/logging
& go-kit/log
& go-kit/kit/log
1 task
johnabass
requested changes
Oct 26, 2022
daa42aa
to
9521c53
Compare
webpa-common/logging
& go-kit/log
& go-kit/kit/log
webpa-common/logging
& webpa-common/bascule*
& go-kit/log
& go-kit/kit/log
johnabass
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
webpa-common archival/deprecation
work related to the archival & deprecation of webpa-common
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step of webpa-common archival.
What's included:
go-kit/kit/log
&go-kit/log
#199closes #186
closes #199
closes #210
webpa-common/logging
Utilities sallust#39