Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tracing Configs #298

Merged
merged 7 commits into from
May 9, 2023
Merged

Update Tracing Configs #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6f7d2a
update candlelight to v0.0.15
renaz6 Mar 14, 2023
c606df1
Add additional tracing configs
renaz6 Mar 14, 2023
ae8dda4
Merge branch 'main' into tracingConfigs
renaz6 Mar 14, 2023
e351ab4
Merge branch 'main' into tracingConfigs
renaz6 Apr 18, 2023
ef49932
revert candlelight to v0.0.15
renaz6 Apr 20, 2023
e0d8411
Merge branch 'tracingConfigs' into tracingConfigs
renaz6 Apr 20, 2023
fb2450c
Merge branch 'main' into tracingConfigs
renaz6 May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/xmidt-org/talaria

go 1.18
go 1.19

require (
github.com/fatih/structs v1.1.0
Expand All @@ -18,7 +18,7 @@ require (
github.com/stretchr/testify v1.8.2
github.com/thedevsaddam/gojsonq/v2 v2.5.2
github.com/xmidt-org/bascule v0.11.0
github.com/xmidt-org/candlelight v0.0.16
github.com/xmidt-org/candlelight v0.0.15
github.com/xmidt-org/clortho v0.0.4
github.com/xmidt-org/sallust v0.2.0
github.com/xmidt-org/touchstone v0.1.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,8 +1002,8 @@ github.com/xmidt-org/bascule v0.11.0 h1:A5RoGFA3XqF7Az1FBF9uEBqhUQ3dLvyhefpS7UkN
github.com/xmidt-org/bascule v0.11.0/go.mod h1:6JnrbmFjVueyUL496MidJYBDotPpuGTGsPOBnCATvQ8=
github.com/xmidt-org/candlelight v0.0.5/go.mod h1:j9Q2tzrOAywm+JvvVJjlOmlPJvdlRrOyFjLz33SaU1Y=
github.com/xmidt-org/candlelight v0.0.10/go.mod h1:Vy5vSLpwDkphgJ2lOOLBlKOjcgSWq3lA8e0yyVzQCJg=
github.com/xmidt-org/candlelight v0.0.16 h1:yrkavbxRC+0gOTxzm6aAVqR78HjNtE+aPrCOq9HHCko=
github.com/xmidt-org/candlelight v0.0.16/go.mod h1:uKs19MQmcrKxFGJhnkVVpEmFJbav5y3jJs30O7204Vo=
github.com/xmidt-org/candlelight v0.0.15 h1:a9tphsYItewWTP7DUpdU7gppljJOoUsgUPpz1P63Dbs=
github.com/xmidt-org/candlelight v0.0.15/go.mod h1:yYzrElo3KP1BZ5GAPus7PXehhe7SJYwt7JwCb/+BWQ0=
github.com/xmidt-org/chronon v0.1.1 h1:SzOYkT/nmps3jH4sWu6A52ToKvv5Bu0Gb45/ec5Ty9U=
github.com/xmidt-org/chronon v0.1.1/go.mod h1:8VF1skJAouQihpKfXE8oZZkbQpV1TSR/7QltNxq8T4k=
github.com/xmidt-org/clortho v0.0.3/go.mod h1:1YypMcDmHVrSqSzpMp4fvwloSKc5PQnHmoaPcKWchHk=
Expand Down
11 changes: 11 additions & 0 deletions talaria.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,17 @@ tracing:
# endpoint is where trace information should be routed. Applies to otlp, zipkin, and jaegar. OTLP/gRPC uses port 4317 by default.
# OTLP/HTTP uses port 4318 by default.
# endpoint: "http://localhost:9411/api/v2/spans"

# ParentBased and NoParent dictate if and when new spans should be created.
# ParentBased = "ignore" (default), tracing is effectively turned off and the "NoParent" value is ignored
# ParentBased = "honor", the sampling decision is made by the parent of the span
parentBased: ignore

# NoParent decides if a root span should be initiated in the case where there is no existing parent
# This value is ignored if ParentBased = "ignore"
# NoParent = "never" (default), root spans are not initiated
# NoParent = "always", roots spans are initiated
noParent: never


zap:
Expand Down