Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tracing Configs #298

Merged
merged 7 commits into from
May 9, 2023
Merged

Update Tracing Configs #298

merged 7 commits into from
May 9, 2023

Conversation

renaz6
Copy link
Member

@renaz6 renaz6 commented Mar 14, 2023 •
edited

@renaz6 renaz6 marked this pull request as draft March 14, 2023 17:52
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@renaz6 renaz6 self-assigned this Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023 •
edited

Codecov Report

Merging #298 (fb2450c) into main (f6d6e4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   60.83%   60.83%           
=======================================
  Files          18       18           
  Lines        1527     1527           
=======================================
  Hits          929      929           
  Misses        584      584           
  Partials       14       14
Flag Coverage Δ
unittests 60.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@renaz6 renaz6 marked this pull request as ready for review April 20, 2023 18:56
@guardrails
Copy link

guardrails bot commented May 5, 2023

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
N/A pkg:golang/github.com/xmidt-org/candlelight@v0.0.15@v0.0.15 - no patch available

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

denopink
denopink approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@renaz6 renaz6 merged commit 54a3548 into main May 9, 2023
16 of 17 checks passed
@renaz6 renaz6 deleted the tracingConfigs branch May 9, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denopink denopink denopink approved these changes

@johnabass johnabass johnabass approved these changes

Assignees

@renaz6 renaz6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Tracing Configurations
3 participants
@renaz6 @denopink @johnabass