-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preliminary integration of webhooks validator #224
Conversation
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 46.63% 46.08% -0.56%
==========================================
Files 13 13
Lines 744 753 +9
==========================================
Hits 347 347
- Misses 391 400 +9
Partials 6 6
Continue to review full report at Codecov.
|
fixes xmidt-org/ancla#14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions that I think will make it easier to understand what the config values do. If they look good to you, please copy them to the main tr1d1um.yaml file 🎉
Co-authored-by: Joel Unzain <joe94@users.noreply.github.com>
Co-authored-by: Joel Unzain <joe94@users.noreply.github.com>
Co-authored-by: Joel Unzain <joe94@users.noreply.github.com>
Co-authored-by: Joel Unzain <joe94@users.noreply.github.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! 💯
No description provided.