Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preliminary integration of webhooks validator #224

Merged
merged 26 commits into from
Sep 13, 2021
Merged

preliminary integration of webhooks validator #224

merged 26 commits into from
Sep 13, 2021

Conversation

mtrinh11
Copy link
Contributor

@mtrinh11 mtrinh11 commented Sep 9, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #224 (7a91b76) into main (3bccfd5) will decrease coverage by 0.55%.
The diff coverage is 0.00%.

❗ Current head 7a91b76 differs from pull request most recent head 80689d0. Consider uploading reports for the commit 80689d0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   46.63%   46.08%   -0.56%     
==========================================
  Files          13       13              
  Lines         744      753       +9     
==========================================
  Hits          347      347              
- Misses        391      400       +9     
  Partials        6        6              
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bccfd5...80689d0. Read the comment docs.

@mtrinh11
Copy link
Contributor Author

fixes xmidt-org/ancla#14

tr1d1um.yaml Outdated Show resolved Hide resolved
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions that I think will make it easier to understand what the config values do. If they look good to you, please copy them to the main tr1d1um.yaml file 🎉

deploy/packaging/tr1d1um_spruce.yaml Outdated Show resolved Hide resolved
deploy/packaging/tr1d1um_spruce.yaml Outdated Show resolved Hide resolved
deploy/packaging/tr1d1um_spruce.yaml Outdated Show resolved Hide resolved
deploy/packaging/tr1d1um_spruce.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
deploy/packaging/tr1d1um_spruce.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
tr1d1um.yaml Outdated Show resolved Hide resolved
mtrinh11 and others added 17 commits September 13, 2021 13:23
Co-authored-by: Joel Unzain <joe94@users.noreply.github.com>
Co-authored-by: Joel Unzain <joe94@users.noreply.github.com>
Co-authored-by: Joel Unzain <joe94@users.noreply.github.com>
Co-authored-by: Joel Unzain <joe94@users.noreply.github.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Co-authored-by: Kristina Pathak <kmspring57@gmail.com>
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 💯

@mtrinh11 mtrinh11 merged commit 683f4c0 into xmidt-org:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants