generated from xmidt-org/.go-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process for Validating a Webhook #14
Comments
Validation could also be configured to ensure the url is a valid URI, removing the need to do it later: |
This would also allow us to check the |
This was referenced Sep 2, 2021
This was referenced Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/xmidt-org/webpa-common/blob/a81c75dd06641b1a9928dcb93f60faeba4eebc3d/webhook/webhook.go#L65
Add a way to validate a webhook, with configurable rules to apply against it. This would allow us to:
There is currently a
sanitize()
function and it may be that parts of that can be incorporated into this.https://github.com/xmidt-org/webpa-common/blob/a81c75dd06641b1a9928dcb93f60faeba4eebc3d/webhook/webhook.go#L86
Then when someone tries to register for a new webhook that's invalid, we can return a 400.
The text was updated successfully, but these errors were encountered: