Reorganize common folder #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 46.44% 47.57% +1.13%
==========================================
Files 13 11 -2
Lines 773 763 -10
==========================================
+ Hits 359 363 +4
+ Misses 405 391 -14
Partials 9 9
Continue to review full report at Codecov.
|
|
fixes #123 |
kristinapathak
suggested changes
Dec 15, 2021
transaction/transactor.go
Outdated
| // keep track of incoming requests and their corresponding responses | ||
| func TransactionLogging(reducedLoggingResponseCodes []int, logger kitlog.Logger) kithttp.ServerFinalizerFunc { | ||
| func Logging(reducedLoggingResponseCodes []int, logger kitlog.Logger) kithttp.ServerFinalizerFunc { |
There was a problem hiding this comment.
Logging is kind of weird, since normally our function verbs are more direct.
Suggested change
| func Logging(reducedLoggingResponseCodes []int, logger kitlog.Logger) kithttp.ServerFinalizerFunc { | |
| func Log(reducedLoggingResponseCodes []int, logger kitlog.Logger) kithttp.ServerFinalizerFunc { |
I also think the logger parameter should be first, but not sure that this pr is a good place to do that.
There was a problem hiding this comment.
I created a ticket for moving the parameter. I've applied the syntax to this pr!
#236
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.