Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v2 / previous version support #249

Merged
merged 3 commits into from
Feb 18, 2022
Merged

add v2 / previous version support #249

merged 3 commits into from
Feb 18, 2022

Conversation

kristinapathak
Copy link
Contributor

fixes #248

@kristinapathak kristinapathak added this to In progress in XMiDT via automation Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #249 (ae2b309) into main (9547ae5) will decrease coverage by 0.97%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   47.45%   46.47%   -0.98%     
==========================================
  Files          12       12              
  Lines         765      781      +16     
==========================================
  Hits          363      363              
- Misses        392      408      +16     
  Partials       10       10              
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
primaryHandler.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9547ae5...ae2b309. Read the comment docs.

XMiDT automation moved this from In progress to PRs: Approved Feb 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kristinapathak kristinapathak merged commit 72c627b into main Feb 18, 2022
XMiDT automation moved this from PRs: Approved to Done Feb 18, 2022
@kristinapathak kristinapathak deleted the v2-api branch February 18, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
XMiDT
  
Done
Development

Successfully merging this pull request may close these issues.

Transition to V3 API must use deprecation over time
3 participants