Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prev version compatible #253

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Prev version compatible #253

merged 5 commits into from
Feb 24, 2022

Conversation

mtrinh11
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/uberfx@711d715). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             feature/uberfx     #253   +/-   ##
=================================================
  Coverage                  ?   43.11%           
=================================================
  Files                     ?       13           
  Lines                     ?      842           
  Branches                  ?        0           
=================================================
  Hits                      ?      363           
  Misses                    ?      469           
  Partials                  ?       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 711d715...e09d515. Read the comment docs.

primaryHandler.go Outdated Show resolved Hide resolved
@kristinapathak
Copy link
Contributor

Pulls in changes from #249

primaryHandler.go Outdated Show resolved Hide resolved
primaryHandler.go Outdated Show resolved Hide resolved
primaryHandler.go Outdated Show resolved Hide resolved
primaryHandler.go Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtrinh11 mtrinh11 merged commit eb3d080 into feature/uberfx Feb 24, 2022
@mtrinh11 mtrinh11 deleted the prevVersionCompatible branch February 24, 2022 17:12
denopink pushed a commit that referenced this pull request Aug 29, 2022
* added previous version capatibility

* fixed viper call

* changed naming and fixed named types for argus and xmidt timeouts

* replaced all viper calls for configuration

* fixed config key issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants