Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Configs for OTLP support #346

Merged
merged 13 commits into from
Jan 10, 2023
Merged

Update Configs for OTLP support #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7859196
Initial Commit
renaz6 Nov 9, 2022
d75eaf9
Merge branch 'main' into renaz6/updateCandlelight
renaz6 Nov 9, 2022
ddaf47f
Update Config for Otel Collector
renaz6 Nov 18, 2022
70d67cd
Update go.mod
renaz6 Nov 18, 2022
7f89e92
Document the config file
renaz6 Nov 30, 2022
9cf24ed
Refined configurations for tracing
renaz6 Dec 5, 2022
b9a98dd
Update tr1d1um.yaml
renaz6 Dec 5, 2022
931ddb0
Update Changelog
renaz6 Dec 5, 2022
290a8da
Update tr1d1um.yaml
renaz6 Dec 6, 2022
3d19788
Merge branch 'main' into renaz6/updateCandlelight
denopink Dec 6, 2022
45a97be
Update modules with new candlelight release
renaz6 Dec 8, 2022
9ae0895
Merge branch 'renaz6/updateCandlelight' of https://github.com/xmidt-o…
renaz6 Dec 8, 2022
ea4e303
Merge branch 'main' into renaz6/updateCandlelight
denopink Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
- Updated tracing configuration documentation in tr1d1um.yaml to reflect changes in Candlelight [#346](https://github.com/xmidt-org/tr1d1um/pull/346)
- [https://github.com/xmidt-org/tr1d1um/issues/340](https://github.com/xmidt-org/tr1d1um/issues/340)
- [v2 & v3 endpoints are not enforcing capabilities xmidt-org/tr1d1um#342](https://github.com/xmidt-org/tr1d1um/issues/342)
- [v3 endpoint is not validating webhooks #341](https://github.com/xmidt-org/tr1d1um/issues/341)
Expand Down
9 changes: 5 additions & 4 deletions tr1d1um.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,19 +379,20 @@ requestMaxRetries: 2
# tracing provides configuration around traces using OpenTelemetry.
# (Optional). By default, a 'noop' tracer provider is used and tracing is disabled.
tracing:
# provider is the provider name. Currently, stdout, jaegar and zipkin are supported.
# provider is the name of the trace provider to use. Currently, otlp/grpc, otlp/http, stdout, jaeger and zipkin are supported.
# 'noop' can also be used as provider to explicitly disable tracing.
provider: "noop"

# skipTraceExport only applies when provider is stdout. Set skipTraceExport to true
# so that trace information is not written to stdout.
# skipTraceExport: true

# endpoint is where trace information should be routed. Applies to zipkin and jaegar.
# endpoint: "http://localhost:9411/api/v2/spans"
# endpoint is where trace information should be routed. Applies to otlp, zipkin, and jaegar. OTLP/gRPC uses port 4317 by default.
# OTLP/HTTP uses port 4318 by default.
# endpoint: "localhost:4317"

# previousVersionSupport allows us to support two different major versions of
# the API at the same time from the same application. When this is true,
# tr1d1um will support both "/v2" and "/v3" endpoints. When false, only "/v3"
# endpoints will be supported.
previousVersionSupport: true
previousVersionSupport: true