Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Configs for OTLP support #346

Merged
merged 13 commits into from
Jan 10, 2023
Merged

Update Configs for OTLP support #346

merged 13 commits into from
Jan 10, 2023

Conversation

renaz6
Copy link
Member

@renaz6 renaz6 commented Nov 30, 2022 •
edited

  • Updated tr1d1um.yaml tracing configs and documentation to reflect the addition of OTLP in Candlelight

@guardrails
Copy link

guardrails bot commented Nov 30, 2022 •
edited

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@renaz6 renaz6 changed the title Renaz6/update candlelight Update Configs for OTLP support Dec 1, 2022
denopink
denopink requested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but checks are failing due to go.sum/candelight issues

@renaz6 renaz6 mentioned this pull request Dec 13, 2022
Closed
11 tasks
denopink
denopink requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove local go mod replace

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited

Codecov Report

Merging #346 (ea4e303) into main (7ddae3e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   43.93%   43.93%           
=======================================
  Files          15       15           
  Lines        1122     1122           
=======================================
  Hits          493      493           
  Misses        618      618           
  Partials       11       11
Flag Coverage Δ
unittests 43.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

denopink
denopink approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged main. lgtm
Cheers! 🍻

@denopink denopink merged commit 1aad8e7 into main Jan 10, 2023
@denopink denopink deleted the renaz6/updateCandlelight branch January 10, 2023 17:33
@denopink denopink mentioned this pull request Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidtw schmidtw schmidtw approved these changes

@denopink denopink denopink approved these changes

@johnabass johnabass johnabass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@renaz6 @schmidtw @denopink @johnabass