Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace go-kit/kit/log & go-kit/log with zap #356

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

denopink
Copy link
Contributor

@denopink denopink added enhancement webpa-common archival/deprecation work related to the archival & deprecation of webpa-common labels Jan 11, 2023
@denopink denopink self-assigned this Jan 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #356 (0a522f4) into main (ebd7188) will increase coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   43.93%   44.13%   +0.19%     
==========================================
  Files          15       15              
  Lines        1122     1117       -5     
==========================================
  Hits          493      493              
+ Misses        618      613       -5     
  Partials       11       11              
Flag Coverage Δ
unittests 44.13% <0.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <ø> (ø)
primaryHandler.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@denopink denopink mentioned this pull request Jan 11, 2023
@guardrails
Copy link

guardrails bot commented Jan 11, 2023

⚠️ We detected 4 security issues in this pull request:

Vulnerable Libraries (4)
Severity Details
High pkg:golang/github.com/hashicorp/consul/sdk@v0.13.0@v0.13.0 - no patch available
High pkg:golang/github.com/hashicorp/consul/api@v1.18.0@v1.18.0 - no patch available
N/A pkg:golang/github.com/aws/aws-sdk-go@v1.44.177 @v1.44.177 - no patch available
N/A pkg:golang/github.com/aws/aws-sdk-go@v1.44.177@v1.44.177 - no patch available

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@denopink denopink merged commit 7e45a73 into main Jan 11, 2023
@denopink denopink deleted the denopink/refactoring/remove-gokit-logging branch January 11, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant