Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sax): Restore ability to parse __prototype__ attributes #315

Merged
merged 3 commits into from
Sep 1, 2021
Merged

fix(sax): Restore ability to parse __prototype__ attributes #315

merged 3 commits into from
Sep 1, 2021

Commits on Sep 1, 2021

  1. fix: Prototype fields conflict with dom attributes 

    As noted in issue xmldom#252 some attributes conflict with prototype fields (such as an attribute `constructor`) thus we must remove the `in` operator and replace with `Object.prototype.hasOwnProperty()`.
    @dsimpsonOMF
    dsimpsonOMF committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    5c9bf42 View commit details
    Browse the repository at this point in the history

  2. style: Prettify changed code

    @karfau
    karfau committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    db7dce6 View commit details
    Browse the repository at this point in the history

  3. test: Add test for fix

    @karfau
    karfau committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    6026d11 View commit details
    Browse the repository at this point in the history